> On June 1, 2015, 11:11 p.m., Hanifi Gunes wrote:
> > exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java, line 319
> > <https://reviews.apache.org/r/34839/diff/2/?file=975896#file975896line319>
> >
> > We should move this allocation out of try-finally.
I've moved the assignment to 'data' buffer inside the try block. I think this would be consistent
having all allocations within the try/catch block and clearing if we encounter failure.
- Mehant
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34839/#review86083
-----------------------------------------------------------
On June 2, 2015, 9:49 p.m., Mehant Baid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34839/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 9:49 p.m.)
>
>
> Review request for drill and Hanifi Gunes.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> While allocating memory for composite vectors if one of the allocation fails we need
to release all the allocated memory upto that point.
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/codegen/templates/NullableValueVectors.java 90ec6be
> exec/java-exec/src/main/codegen/templates/RepeatedValueVectors.java 7b2b78d
> exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java b3389e2
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/AbstractMapVector.java
3c01939
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/BaseRepeatedValueVector.java
PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java
a97847b
>
> Diff: https://reviews.apache.org/r/34839/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mehant Baid
>
>
|