drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Barclay" <dbarc...@maprtech.com>
Subject Review Request 35047: DRILL-2089: Part 2--Split Driver into published Driver and internal DriverImpl.
Date Thu, 04 Jun 2015 06:43:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35047/
-----------------------------------------------------------

Review request for drill, Mehant Baid and Parth Chandra.


Bugs: DRILL-2089
    https://issues.apache.org/jira/browse/DRILL-2089


Repository: drill-git


Description
-------

Split original Driver class into new Driver and DriverImpl classes (to remove
implementation details from JDBC's published interface (i.e., extension of
Avatica UnregisteredDriver)):
    
Moved most of original Driver to new DriverImpl.  (Excluded registration code.)
    
Created new Driver class:
- implementing java.sql.Driver (not extending Avatica UnregisteredDriver)
- providing java.sql.Driver methods via delegation to a private DriverImpl instance (not via
extension)
- having driver registration code
    
Updated internal references to Driver to DriverImpl.  [DrillConnectionImpl,
DrillFactory, and DrillJdbc41Factory]


Diffs
-----

  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java 5f82054 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillFactory.java c674f8e 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillJdbc41Factory.java 93fe59d 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/Driver.java 55453e8 
  exec/jdbc/src/main/java/org/apache/drill/jdbc/DriverImpl.java PRE-CREATION 

Diff: https://reviews.apache.org/r/35047/diff/


Testing
-------

Ran existing tests.  (With parts 1 through 7 together.)


Thanks,

Daniel Barclay


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message