drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aman Sinha" <asi...@maprtech.com>
Subject Re: Review Request 35365: DRILL-3182, DRILL-3188, DRILL-3195
Date Thu, 11 Jun 2015 23:20:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35365/#review87639
-----------------------------------------------------------



exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java
<https://reviews.apache.org/r/35365/#comment140030>

    Instead of 'disabled' we should be consistent with the error messages and say 'The window
function <name> is not currently supported <rest of the message>'



exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java
<https://reviews.apache.org/r/35365/#comment140039>

    Change to 'DISTINCT for window aggregate functions is not currently supported...'  (since
DISTINCT only applies to window aggregates not to rank, dense_rank etc.)



exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java
<https://reviews.apache.org/r/35365/#comment140048>

    Instead of using string comparisons, we should use the methods SqlWindow.isCurrentRow(),
SqlWindow.isUnboundedPreceding() etc.  or the enum Bound.



exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java
<https://reviews.apache.org/r/35365/#comment140042>

    On the latest master branch, the window.enable option is now set to true, so you can remove
these from the unit tests.



exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java
<https://reviews.apache.org/r/35365/#comment140045>

    For conciseness, it would be better to have a single test which has a query string which
takes various types of windows functions that are unsupported (lead, lag etc.) and just runs
them one by one.  This will reduce the duplication. In any case, in a subsequent release we
will be supporting these functions.


- Aman Sinha


On June 11, 2015, 8:33 p.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35365/
> -----------------------------------------------------------
> 
> (Updated June 11, 2015, 8:33 p.m.)
> 
> 
> Review request for drill, Aman Sinha and Jinfeng Ni.
> 
> 
> Bugs: DRILL-3182, DRILL-3188 and DRILL-3195
>     https://issues.apache.org/jira/browse/DRILL-3182
>     https://issues.apache.org/jira/browse/DRILL-3188
>     https://issues.apache.org/jira/browse/DRILL-3195
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Window function with DISTINCT qualifier is disabled; Disable unsupported window frames;
Window functions NTILE, LAG, LEAD, FIRST_VALUE, LAST_VALUE are disabled
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java
b92de3b 
>   exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java fc75d73

> 
> Diff: https://reviews.apache.org/r/35365/diff/
> 
> 
> Testing
> -------
> 
> All the required tests
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message