-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35393/#review87899
-----------------------------------------------------------
Does the constant argument work for something other than COUNT ? For instance:
SELECT SUM(5) OVER (partition by <column>) FROM t;
I think this may produce wrong result but that may be a separate issue...
- Aman Sinha
On June 12, 2015, 5:40 p.m., abdelhakim deneche wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35393/
> -----------------------------------------------------------
>
> (Updated June 12, 2015, 5:40 p.m.)
>
>
> Review request for drill and Aman Sinha.
>
>
> Bugs: DRILL-3220
> https://issues.apache.org/jira/browse/DRILL-3220
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Made changes to DrillWindowRule and WindowPrel to properly handle constants in OVER clause
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillWindowRule.java
76939d9
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/WindowPrel.java
4f6551a
> exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/window/TestWindowFrame.java
4295002
> exec/java-exec/src/test/resources/window/q1.sql PRE-CREATION
> exec/java-exec/src/test/resources/window/q2.sql PRE-CREATION
> exec/java-exec/src/test/resources/window/q3218.sql PRE-CREATION
> exec/java-exec/src/test/resources/window/q3220.sql PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35393/diff/
>
>
> Testing
> -------
>
> all unit tests are passing along with functional and tpch100
>
>
> Thanks,
>
> abdelhakim deneche
>
>
|