drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aman Sinha" <asi...@maprtech.com>
Subject Re: Review Request 35851: DRILL-3359: Drill should throw and error when window function defined using WINDOW AS
Date Thu, 25 Jun 2015 04:20:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35851/#review89312
-----------------------------------------------------------

Ship it!


Ship It!

- Aman Sinha


On June 24, 2015, 11:49 p.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35851/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 11:49 p.m.)
> 
> 
> Review request for drill and Aman Sinha.
> 
> 
> Bugs: DRILL-3359
>     https://issues.apache.org/jira/browse/DRILL-3359
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Also detect the window frame claimed in the window definition
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java
0c5afc1 
>   exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java e8daff2

> 
> Diff: https://reviews.apache.org/r/35851/diff/
> 
> 
> Testing
> -------
> 
> unit test is done; 
> others are in the line
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message