From dev-return-14023-apmail-drill-dev-archive=drill.apache.org@drill.apache.org Wed Jun 3 00:36:29 2015 Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5DB0917CC1 for ; Wed, 3 Jun 2015 00:36:29 +0000 (UTC) Received: (qmail 99755 invoked by uid 500); 2 Jun 2015 21:49:48 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 99703 invoked by uid 500); 2 Jun 2015 21:49:48 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 99692 invoked by uid 500); 2 Jun 2015 21:49:48 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 99687 invoked by uid 99); 2 Jun 2015 21:49:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jun 2015 21:49:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 52C801DE5C3; Tue, 2 Jun 2015 21:49:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3977101376428292550==" MIME-Version: 1.0 Subject: Re: Review Request 34839: DRILL-3155: Part 2 From: "Mehant Baid" To: "Hanifi Gunes" Cc: "Mehant Baid" , "drill" Date: Tue, 02 Jun 2015 21:49:48 -0000 Message-ID: <20150602214948.1498.93128@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Mehant Baid" X-ReviewGroup: drill-git X-ReviewRequest-URL: https://reviews.apache.org/r/34839/ X-Sender: "Mehant Baid" References: <20150601205453.3246.57570@reviews.apache.org> In-Reply-To: <20150601205453.3246.57570@reviews.apache.org> Reply-To: "Mehant Baid" X-ReviewRequest-Repository: drill-git --===============3977101376428292550== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34839/ ----------------------------------------------------------- (Updated June 2, 2015, 9:49 p.m.) Review request for drill and Hanifi Gunes. Changes ------- Addressed review comments Repository: drill-git Description ------- While allocating memory for composite vectors if one of the allocation fails we need to release all the allocated memory upto that point. Diffs (updated) ----- exec/java-exec/src/main/codegen/templates/NullableValueVectors.java 90ec6be exec/java-exec/src/main/codegen/templates/RepeatedValueVectors.java 7b2b78d exec/java-exec/src/main/codegen/templates/VariableLengthVectors.java b3389e2 exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/AbstractMapVector.java 3c01939 exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/BaseRepeatedValueVector.java PRE-CREATION exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java a97847b Diff: https://reviews.apache.org/r/34839/diff/ Testing ------- Thanks, Mehant Baid --===============3977101376428292550==--