From dev-return-14524-apmail-drill-dev-archive=drill.apache.org@drill.apache.org Wed Jun 24 22:16:54 2015 Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 93F4A17522 for ; Wed, 24 Jun 2015 22:16:53 +0000 (UTC) Received: (qmail 93458 invoked by uid 500); 24 Jun 2015 22:16:53 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 93407 invoked by uid 500); 24 Jun 2015 22:16:53 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 93396 invoked by uid 500); 24 Jun 2015 22:16:53 -0000 Delivered-To: apmail-incubator-drill-dev@incubator.apache.org Received: (qmail 93390 invoked by uid 99); 24 Jun 2015 22:16:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Jun 2015 22:16:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 086DDA9E6B; Wed, 24 Jun 2015 22:16:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4679718831663596205==" MIME-Version: 1.0 Subject: Re: Review Request 35845: DRILL-3345: TestWindowFrame fails to properly check cases involving multiple batches From: "Aman Sinha" To: "Aman Sinha" , "Steven Phillips" Cc: "abdelhakim deneche" , "drill" Date: Wed, 24 Jun 2015 22:16:52 -0000 Message-ID: <20150624221652.3114.96775@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aman Sinha" X-ReviewGroup: drill-git X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/35845/ X-Sender: "Aman Sinha" References: <20150624212427.3113.21600@reviews.apache.org> In-Reply-To: <20150624212427.3113.21600@reviews.apache.org> Reply-To: "Aman Sinha" X-ReviewRequest-Repository: drill-git --===============4679718831663596205== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35845/#review89263 ----------------------------------------------------------- exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/DefaultFrameTemplate.java (line 245) If you are going to leave this commented-out line in the code, it would be good to add a comment to indicate that the WF computation of a partition can only start after all batches of that partition have been received, not enough to have the last peer row. - Aman Sinha On June 24, 2015, 9:24 p.m., abdelhakim deneche wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35845/ > ----------------------------------------------------------- > > (Updated June 24, 2015, 9:24 p.m.) > > > Review request for drill, Aman Sinha and Steven Phillips. > > > Bugs: DRILL-3345 > https://issues.apache.org/jira/browse/DRILL-3345 > > > Repository: drill-git > > > Description > ------- > > Updated MSorter and SelectionVector4 to allow setting a desired record batch count > > > Diffs > ----- > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/DefaultFrameTemplate.java ada068b > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/MSortTemplate.java 6686fbe > exec/java-exec/src/main/java/org/apache/drill/exec/record/selection/SelectionVector4.java 69bc78f > > Diff: https://reviews.apache.org/r/35845/diff/ > > > Testing > ------- > > ongoing... > > > Thanks, > > abdelhakim deneche > > --===============4679718831663596205==--