drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Hsuan-Yi Chu" <hsua...@usc.edu>
Subject Re: Review Request 32248: DRILL-2139: Star is not expanded correctly in "select distinct" query
Date Thu, 01 Oct 2015 22:09:48 GMT


> On Oct. 1, 2015, 2:11 a.m., Jacques Nadeau wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/AggregateUtils.java,
line 32
> > <https://reviews.apache.org/r/32248/diff/6/?file=1088203#file1088203line32>
> >
> >     Can you add a Javadoc here?

Done


> On Oct. 1, 2015, 2:11 a.m., Jacques Nadeau wrote:
> > exec/java-exec/src/test/java/org/apache/drill/TestDistinctStar.java, line 25
> > <https://reviews.apache.org/r/32248/diff/6/?file=1088207#file1088207line25>
> >
> >     Can you add a test for something that has a known schema select * distinct?

add two; one for streamagg; the other for hash agg;


- Sean Hsuan-Yi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32248/#review101186
-----------------------------------------------------------


On Oct. 1, 2015, 3:18 p.m., Sean Hsuan-Yi Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32248/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2015, 3:18 p.m.)
> 
> 
> Review request for drill, Aman Sinha, Jacques Nadeau, and Jinfeng Ni.
> 
> 
> Bugs: DRILL-2139
>     https://issues.apache.org/jira/browse/DRILL-2139
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Expand * at the run time
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/AggregateUtils.java
PRE-CREATION 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java
a033a8e 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggBatch.java
2ab1e66 
>   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
49a64cf 
>   exec/java-exec/src/test/java/org/apache/drill/TestDistinctStar.java PRE-CREATION 
>   exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/agg/TestHashAggr.java
3786bfd 
>   exec/java-exec/src/test/resources/store/text/data/repeatedRows.json PRE-CREATION 
>   exec/java-exec/src/test/resources/testframework/testDistinctStar/testSelectDistinct.tsv
PRE-CREATION 
>   exec/java-exec/src/test/resources/testframework/testDistinctStar/testSelectDistinctExpression.tsv
PRE-CREATION 
>   exec/java-exec/src/test/resources/testframework/testDistinctStar/testSelectDistinctOverJoin.tsv
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32248/diff/
> 
> 
> Testing
> -------
> 
> Unit and all QA tests passed.
> 
> 
> Thanks,
> 
> Sean Hsuan-Yi Chu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message