drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mehant <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3947: Use setSafe() for date, time, time...
Date Mon, 19 Oct 2015 03:36:33 GMT
Github user mehant commented on the pull request:

    https://github.com/apache/drill/pull/208#issuecomment-149087927
  
    +1. 
    
    Changes look fine to me, given that all the other types use setSafe() it makes sense to
use the same method for DATE, TIMESTAMP for consistency. However I feel that we might be addressing
a symptom here, do you have any thoughts on what the actual issue might be?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message