drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3802: Throw unsupported error for Rollup...
Date Wed, 21 Oct 2015 20:43:05 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/209#discussion_r42679515
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java
---
    @@ -305,6 +313,105 @@ public SqlNode visit(SqlCall sqlCall) {
         return sqlCall.getOperator().acceptCall(this, sqlCall);
       }
     
    +  private void checkRollupCubeGrpSets(SqlSelect sqlSelect) {
    +    final ExprFinder rollupCubeGrpSetsFinder = new ExprFinder(RollupCubeGrpSets);
    +    sqlSelect.accept(rollupCubeGrpSetsFinder);
    +    if (rollupCubeGrpSetsFinder.find()) {
    +      unsupportedOperatorCollector.setException(SqlUnsupportedException.ExceptionType.FUNCTION,
    --- End diff --
    
    Good point. I'll create an enhancement JIRA and point to the enhancement JIRA in the error
msg.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message