drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dsbos <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-2288: Fix ScanBatch violation of IterOut...
Date Mon, 02 Nov 2015 18:57:44 GMT
Github user dsbos commented on a diff in the pull request:

    https://github.com/apache/drill/pull/228#discussion_r43665769
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
    @@ -122,6 +122,7 @@ protected void killIncoming(final boolean sendUpstream) {
     
       @Override
       public IterOutcome innerNext() {
    +    recordCount = 0;
    --- End diff --
    
    That wouldn't have worked--the recordCount fields are declared in the subclasses, not
in one of those superclasses. 
    
    (I didn't try refactoring recordCount up into one of those base classes because I was
already running into enough downstream problems every time I fixed an upstream increment.)
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message