> On June 30, 2015, 7:55 p.m., Sudheesh Katkam wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java,
line 148
> > <https://reviews.apache.org/r/35719/diff/1/?file=989317#file989317line148>
> >
> > The RPC thread could potentially spend quite some time in this method. Why not
a secondary thread here? Or is there a reason why you haven't done this already?
Not a problem since this patch moves execution off the rpc thread.
> On June 30, 2015, 7:55 p.m., Sudheesh Katkam wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java,
line 207
> > <https://reviews.apache.org/r/35719/diff/1/?file=989317#file989317line207>
> >
> > Why create a SerializedExecutor? Why not simply:
> > ```java
> > fragmentContext.getExecutor().execute(new ReceiverFinished(handle));
> > ```
> > and synchronization issues could be handled by RootExec#receivingFragmentFinished
(partitioned sender already does this).
It doesn't make sense to have 10s or 100s of threads to all sit on a binding variable when
we can simply serialize.
- Jacques
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35719/#review89808
-----------------------------------------------------------
On June 22, 2015, 12:40 a.m., Jacques Nadeau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35719/
> -----------------------------------------------------------
>
> (Updated June 22, 2015, 12:40 a.m.)
>
>
> Review request for drill, Chris Westin, Steven Phillips, and Sudheesh Katkam.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> - Add new SerializedExecutor (by cwestin) to manage serialized off-thread executions
> - Create a separate serialized executor for fragment receiverFinished events.
> - Update serialized executor to pool object creation.
> - Ensure that FragmentExecutor acceptExternalEvents countdown occurs when only execution
is cancellation.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/drill/common/SerializedExecutor.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java c642c4a
> exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java 1cbe886
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/RpcBus.java 9ca09a1
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/RpcConfig.java ab6c375
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlClient.java 159f1df
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlRpcConfig.java
0cfa56e
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlServer.java 98ce9e1
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataClient.java 544bab9
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataConnectionCreator.java
a76d753
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataConnectionManager.java
8a947a9
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataResponseHandler.java
721b83e
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataRpcConfig.java c5cf498
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataServer.java 80d2d6e
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java b39a103
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserRpcConfig.java 3f8122d
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java a197356
> exec/java-exec/src/main/java/org/apache/drill/exec/server/BootStrapContext.java d0a998e
> exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitContext.java 6fdbfca
> exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java 25ea307
> exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java 5939113
> exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java
a9c2b6d
> exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestOptiqPlans.java
dc37071
>
> Diff: https://reviews.apache.org/r/35719/diff/
>
>
> Testing
> -------
>
> in progress
>
>
> Thanks,
>
> Jacques Nadeau
>
>
|