drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3941: Add timing instrumentation in diff...
Date Tue, 03 Nov 2015 01:06:31 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/230#discussion_r43706257
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
---
    @@ -166,16 +174,28 @@ protected void doOnMatch(RelOptRuleCall call, DrillFilterRel filterRel,
DrillPro
         }
     
         if (partitionColumnBitSet.isEmpty()) {
    -      logger.debug("No partition columns are projected from the scan..continue.");
    +      logger.info("No partition columns are projected from the scan..continue. " +
    +          "Total pruning elapsed time: {} ms", totalPruningTime.elapsed(TimeUnit.MILLISECONDS));
    --- End diff --
    
    When the pruning rule does early return due to non-applicability, the 'Total pruning elapsed
time' message could be misleading since it did not actually do pruning.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message