drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-2288: Fix ScanBatch violation of IterOut...
Date Tue, 03 Nov 2015 05:23:08 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/228#discussion_r43717182
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
    @@ -325,10 +325,13 @@ public AggOutcome doWork() {
                     if (EXTRA_DEBUG_1) {
                       logger.debug("Received new schema.  Batch has {} records.", incoming.getRecordCount());
                     }
    -                newSchema = true;
    -                this.cleanup();
    -                // TODO: new schema case needs to be handled appropriately
    -                return AggOutcome.UPDATE_AGGREGATOR;
    +                final BatchSchema newIncomingSchema = incoming.getSchema();
    +                if ((! newIncomingSchema.equals(schema)) && schema != null) {
    --- End diff --
    
    You shouldn't put a hack in to ignore a valid schema change. I don't know all the details
but if this is related to HBase, my thought is you probably need to resolve 4010 to avoid
spurious schema changes. You should make sure to avoid propagating schema changes that are
not real/required. Solving on a particular operator just means if the query plan changes,
you'll probably get an error in a different operator. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message