drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From abhipol <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-951:CSV header row should be parsed
Date Tue, 03 Nov 2015 07:21:09 GMT
Github user abhipol commented on a diff in the pull request:

    https://github.com/apache/drill/pull/232#discussion_r43721290
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/TextParsingSettings.java
---
    @@ -57,6 +56,14 @@ public void set(TextFormatConfig config){
         this.delimiter = bSafe(config.getFieldDelimiter(), "fieldDelimiter");
         this.comment = bSafe(config.getComment(), "comment");
         this.skipFirstLine = config.isSkipFirstLine();
    +    //TODO: avoid specific extension based check
    --- End diff --
    
    csvh is part of the format plugin config
    added extractHeader property and cleared the TextParsingSettings code. will upload with
other changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message