drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3171: handle concurrent Zookeeper node c...
Date Thu, 19 Nov 2015 21:47:37 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/260#discussion_r45405445
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/zk/ZkEStore.java
---
    @@ -17,40 +17,25 @@
      */
     package org.apache.drill.exec.store.sys.zk;
     
    +import java.io.IOException;
    +
     import org.apache.curator.framework.CuratorFramework;
     import org.apache.drill.exec.store.sys.EStore;
     import org.apache.drill.exec.store.sys.PStoreConfig;
     import org.apache.zookeeper.CreateMode;
     
    -import java.io.IOException;
    -
     /**
      * Implementation of EStore using Zookeeper's EPHEMERAL node.
      * @param <V>
      */
    -public class ZkEStore<V> extends ZkAbstractStore<V> implements EStore<V>{
    +public class ZkEStore<V> extends ZkAbstractStore<V> implements EStore<V>
{
     
    -  public ZkEStore(CuratorFramework framework, PStoreConfig<V> config) throws IOException{
    +  public ZkEStore(CuratorFramework framework, PStoreConfig<V> config) throws IOException
{
         super(framework,config);
       }
     
       @Override
    -  public void delete(String key) {
    -    try {
    -      if (framework.checkExists().forPath(p(key)) != null) {
    -        framework.delete().forPath(p(key));
    --- End diff --
    
    Previously the node was not rebuilt for ZkEStore (see `childrenCache.rebuildNode(withPrefix(key))`
in ZkAbstractStore). Is this change necessary?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message