drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3623: Use shorter query path for LIMIT 0...
Date Thu, 19 Nov 2015 21:58:56 GMT
Github user jinfengni commented on a diff in the pull request:

    --- Diff: contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java
    @@ -42,6 +43,25 @@ public void hiveReadWithDb() throws Exception {
    +  public void simpleLimitZero() throws Exception {
    +    testBuilder()
    +        .sqlQuery("select * from hive.kv limit 0")
    +        .expectsEmptyResultSet()
    +        .baselineColumns("key", "value")
    --- End diff --
    In the test with schemed "limit 0" case, I think we had better verify the column type
as well. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message