drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adeneche <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-2618: handle queries over empty folders ...
Date Thu, 19 Nov 2015 22:47:14 GMT
Github user adeneche commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java
    @@ -19,82 +19,72 @@
     import java.io.IOException;
     import java.net.URI;
    -import java.util.Collections;
     import java.util.List;
    -import java.util.concurrent.TimeUnit;
    -import com.google.common.base.Stopwatch;
    -import org.apache.commons.lang3.ArrayUtils;
    -import org.apache.commons.lang3.StringUtils;
    -import org.apache.drill.exec.store.parquet.Metadata.ParquetTableMetadata_v1;
    -import org.apache.hadoop.fs.FileStatus;
    -import org.apache.hadoop.fs.Path;
    +import javax.annotation.Nullable;
     import com.fasterxml.jackson.annotation.JsonIgnore;
    +import com.google.common.base.Preconditions;
    +import com.google.common.base.Predicate;
    +import com.google.common.base.Strings;
    +import com.google.common.collect.Iterables;
     import com.google.common.collect.Lists;
    +import org.apache.hadoop.fs.FileStatus;
    +import org.apache.hadoop.fs.Path;
    - * Jackson serializable description of a file selection. Maintains an internal set of
file statuses. However, also
    - * serializes out as a list of Strings. All accessing methods first regenerate the FileStatus
objects if they are not
    - * available.  This allows internal movement of FileStatus and the ability to serialize
if need be.
    + * Jackson serializable description of a file selection.
     public class FileSelection {
       static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(FileSelection.class);
    -  private List<FileStatus> statuses;
    +  public List<FileStatus> statuses;
    --- End diff --
    Only `ParquetFileSelection` requires this to be public. Can we make this private and another
constructor instead ?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message