drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dsbos <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-2288: Fix ScanBatch violation of IterOut...
Date Mon, 02 Nov 2015 04:27:24 GMT
GitHub user dsbos opened a pull request:


    DRILL-2288: Fix ScanBatch violation of IterOutcome protocol and downstream chain of bugs


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dsbos/incubator-drill bugs/drill-2288_etc

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #228
commit faefc960f1a36cf25fa0b553bab75e1c3fc71222
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-10-28T02:25:25Z

    2288:  Pt. 1 Core:  Added unit test.  [Drill2288GetColumnsMetadataWhenNoRowsTest, empty.json]

commit 396a41b155d1ad9413897ae4d87db2337642a1ea
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-11-01T03:36:12Z

    2288:  Pt. 1 Core:  Changed HBase test table #1's # of regions from 1 to 2.  [HBaseTestsSuite]
    Also added TODO(DRILL-3954) comment about # of regions.

commit a0fe6b0787c284cda2006355e507c7caa6cae2a7
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-10-28T02:35:11Z

    2288:  Pt. 2 Core:  Documented IterOutcome much more clearly.  [RecordBatch]
    Also edited some related Javadoc.

commit 24b3f4df90711b630b30fe4e2ad68ff798e5731a
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-10-28T02:41:04Z

    2288:  Pt. 2 Hyg.:  Edited doc., added @Override, etc.  [AbstractRecordBatch, RecordBatch]
    Purged unused SetupOutcome.
    Added @Override.
    Edited comments.
    Fix some comments to doc. comments.

commit a3108ab18e5f99e9d18f57786b2efa717a61c432
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-10-28T03:00:26Z

    2288:  Pt. 3 Core&Hyg.:  Added validation of IterOutcome sequence.  [IteratorValidatorBatchIterator]
    Renamed internal members for clarity.
    Added comments.

commit c8fc4b3f5c3df5871a9b07b8f4ae800ddbe0ce64
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-10-28T03:31:14Z

    2288:  Pt. 4 Core:  Fixed a NONE -> OK_NEW_SCHEMA in ScanBatch.next().  [ScanBatch]
    (With nearby comments.)

commit fcb1438724df83865a83749b097ca19d21cec444
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-10-28T03:56:33Z

    2288:  Pt. 4 Hyg.:  Edited comments, reordered, whitespace.  [ScanBatch]
    Added comments.

commit 9520345aae524d246876a744a8a676e00b0294dc
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-10-28T04:02:25Z

    2288:  Pt. 4 Core+:  Fixed UnionAllRecordBatch to receive IterOutcome sequence right.
 (3659)  [UnionAllRecordBatch]

commit 3acf8ec8927974901d825859c8f00d1382aa2d87
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-10-28T04:05:01Z

    2288:  Pt. 5 Core:  Fixed ScanBatch.Mutator.isNewSchema() to stop spurious "new schema"
reports (fix short-circuit OR, to call resetting method right).  [ScanBatch]

commit 59ede9bda0e73c0bb6840018781f1f404d73f85c
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-10-28T04:11:55Z

    2288:  Pt. 5 Hyg.:  Renamed, edited comments, reordered.  [ScanBatch, SchemaChangeCallBack,
    Renamed getSchemaChange -> getSchemaChangedAndReset.
    Renamed schemaChange -> schemaChanged.
    Added doc. comments.

commit d93dc1ee518db409e72b8672679640be65ae7a62
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-10-28T04:20:47Z

    2288:  Pt. 6 Core:  Avoided dummy Null.IntVec. column in JsonReader when not needed (MapWriter.isEmptyMap()).
 [JsonReader, 3 vector files]

commit f989229ac5510273698af19d87b50044efed81c5
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-10-28T04:32:44Z

    2288:  Pt. 6 Hyg.:  Edited comments, message.  Fixed message formatting.  [RecordReader,
JSONFormatPlugin, JSONRecordReader, AbstractMapVector, JsonReader]
    Fixed message formatting.
    Edited comments.
    Edited message.
    Fixed spurious line break.

commit a360e9d0d7bfac0aa75831c35585f8ea890858dc
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-10-28T05:06:13Z

    2288:  Pt. 7 Core:  Added column families in HBaseRecordReader* to avoid dummy Null.IntVec.
clash.  [HBaseRecordReader]

commit 18467a9ce14f6328b4766541267183927ebcdc9c
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-10-28T05:06:52Z

    2288:  Pt. 8 Core.1:  Cleared recordCount in OrderedPartitionRecordBatch.innerNext().

commit 73bf71fc4af8e54599e908abbb993a64b066c097
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-10-28T05:07:14Z

    2288:  Pt. 8 Core.2:  Cleared recordCount in ProjectRecordBatch.innerNext.  [ProjectRecordBatch]

commit 064187d1c23f2b4fc09e94066d66e79ef961c4f1
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-10-28T05:08:22Z

    2288:  Pt. 8 Core.3:  Cleared recordCount in TopNBatch.innerNext.  [TopNBatch]

commit 8b9d1657ee22cee4432074f778e5d10e2c06e8e8
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-10-28T05:24:35Z

    2288:  Pt. 9 Core:  Had UnorderedReceiverBatch reset RecordBatchLoader's record count.
 [UnorderedReceiverBatch, RecordBatchLoader]

commit 57c36854d6b65107d46b547fd9edd351c3149643
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-10-29T00:28:50Z

    2288:  Pt. 10 Core:  Worked around mismatched map child vectors in MapVector.getObject().

commit 0939660f4620c03da97f4e1bf25a27514e6d0b81
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-10-30T00:33:20Z

    2288:  Pt. 11 Core:  Added OK_NEW_SCHEMA schema comparison for HashAgg.  [HashAggTemplate]

commit 01d7a6ee4b8a358b1a2da6ea974fe36b54497818
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-10-30T20:33:27Z

    2288:  Pt. 9 Hyg.:  Added comments.  [RecordBatchLoader]

commit c58390a7b3fbfcd34b179b1c5b1d599e65f6995c
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-11-01T21:40:11Z

    2288:  Pt. 12 Core:  Fixed memory leak in BaseTestQuery's printing.
    Fixed bad skipping of RecordBatchLoader.clear(...) and
    QueryDataBatch.load(...) for zero-row batches in printResult(...).
    Also, dropped suppression of call to
    VectorUtil.showVectorAccessibleContent(...) (so zero-row batches are
    as visible as others).

commit cd792fb0ef29b415034a33efa3e711c129f8a252
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-10-28T05:13:49Z

    2288:  Misc.:  Added simple/partial toString() [VectorContainer, AbstractRecordReader,
JSONRecordReader, BaseValueVector, FieldSelection, AbstractBaseWriter]

commit 2d0991be55f83043c8233c9c7caca35a9c25d0e3
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-10-28T06:44:11Z

    2288:  Misc.:  Added # of rows to showVectorAccessibleContent's output.  [VectorUtil]

commit 8f60503e15b61fa40528caa587d9c5be5f66f786
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-10-29T00:34:58Z

    2288:  Misc. Hyg.:  Added doc. comments to VectorContainer.  [VectorContainer]

commit 4651417b67bbfe197167cec9849a548bef40d797
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-10-30T22:46:08Z

    2288:  Misc. Hyg.:  Edited comment.  [DrillStringUtils]

commit 84693d0df51ad129dc7f343791c145d817895a61
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-11-01T20:24:35Z

    2288:  Pt. 13 Core:  Fixed test that used unhandled periods in column alias identifiers.

commit 37da4d65932b9450564e29b3df9d11cba1ef9389
Author: dbarclay <dbarclay@maprtech.com>
Date:   2015-11-01T21:45:37Z

    2288:  Misc. Hyg.:  Clarified message for unhandled identifier containing period.


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message