drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adeneche <...@git.apache.org>
Subject [GitHub] drill pull request: Drill 4236: ExternalSort should use the new al...
Date Tue, 05 Jan 2016 21:35:48 GMT
Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/317#discussion_r48899265
  
    --- Diff: common/src/main/java/org/apache/drill/common/exceptions/UserException.java ---
    @@ -50,7 +50,15 @@
        */
       public static Builder memoryError(final Throwable cause) {
         return UserException.resourceError(cause)
    -      .message(MEMORY_ERROR_MSG);
    +      .message(MEMORY_ERROR_MSG).addContext(cause.getMessage());
    +  }
    +
    +  public static Builder memoryError(final String message) {
    +    Builder builder =  UserException.resourceError();
    +    if (!message.isEmpty()) {
    --- End diff --
    
    Oups, this method doesn't set the proper error message to the user exception, it's causing
TestOutOfMemoryOutcome to fail.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message