drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaltekruse <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-2653: Improve web UI experience when the...
Date Thu, 28 Jan 2016 20:54:12 GMT
Github user jaltekruse commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/resources/rest/storage/update.ftl ---
    @@ -53,8 +53,17 @@
         function doUpdate() {
           $("#updateForm").ajaxForm(function(data) {
    -        $("#message").removeClass("hidden").text(data.result).alert();
    -        setTimeout(function() { location.reload(); }, 800);
    +        var messageEl = $("#message");
    +        messageEl.addClass("hidden");
    +        // Wait a fraction of a second before showing the message again. This
    +        // makes it clear if a second attempt gives the same error as
    +        // the first that a "new" message came back from the server
    +        setTimeout(function() {
    +          messageEl.removeClass("hidden").text("Please retry: " + data.result).alert();
    --- End diff --
    Originally I didn't have the "Please retry:" I had added that after finding your patch.
Previously, it would just show either the error or the success message and only in the case
of the success message reload. Will push a fix

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message