drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill issue #675: DRILL-5094: Comparator should guarantee transitive attribu...
Date Mon, 05 Dec 2016 01:52:12 GMT
Github user amansinha100 commented on the issue:

    https://github.com/apache/drill/pull/675
  
    To clarify, I decided to accept the fix because in the context of the comparator call,
the o2.getValue() should never be negative (since it is the #bytes of data used for affinity).
 Strictly speaking, @laurentgo is right about potential for overflow for the subtraction,
so I would suggest @chunhui-shi keep that in mind for future, particularly since it doesn't
make sense to try and optimize this particular code path given that it is a one-time planner
decision, not run-time code :)  Let's move on to more complex problems :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message