drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #666: DRILL-4956: Temporary tables support
Date Tue, 06 Dec 2016 06:12:26 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/666#discussion_r90690504
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/FileSystemCreateTableEntry.java
---
    @@ -47,28 +47,33 @@
       private FormatPlugin formatPlugin;
       private String location;
       private final List<String> partitionColumns;
    +  private final StorageStrategy storageStrategy;
     
       @JsonCreator
       public FileSystemCreateTableEntry(@JsonProperty("storageConfig") FileSystemConfig storageConfig,
                                         @JsonProperty("formatConfig") FormatPluginConfig
formatConfig,
                                         @JsonProperty("location") String location,
                                         @JsonProperty("partitionColumn") List<String>
partitionColumns,
    +                                    @JsonProperty("storageStrategy") StorageStrategy
storageStrategy,
    --- End diff --
    
    Not sure of the semantics here. If we add a new property, will new Drillbits work with
old ones (that don't serialize the property)? Is this something we should handle? Or, should
we make clear that, when switching to the version of Drill with this change, ALL Drillbits
must be upgraded simultaneously?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message