drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sohami <...@git.apache.org>
Subject [GitHub] drill pull request #978: DRILL-5842: Refactor and simplify the fragment, ope...
Date Wed, 01 Nov 2017 00:14:59 GMT
Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/978#discussion_r148146597
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/OperatorContextImpl.java
---
    @@ -17,33 +17,23 @@
      */
     package org.apache.drill.exec.ops;
     
    -import java.io.IOException;
     import java.security.PrivilegedExceptionAction;
     import java.util.concurrent.Callable;
    -import java.util.concurrent.ExecutorService;
     
    -import org.apache.drill.common.exceptions.DrillRuntimeException;
     import org.apache.drill.exec.exception.OutOfMemoryException;
     import org.apache.drill.exec.physical.base.PhysicalOperator;
    -import org.apache.drill.exec.store.dfs.DrillFileSystem;
     import org.apache.drill.exec.work.WorkManager;
    -import org.apache.hadoop.conf.Configuration;
     import org.apache.hadoop.security.UserGroupInformation;
     
    -import com.google.common.base.Preconditions;
     import com.google.common.util.concurrent.ListenableFuture;
     import com.google.common.util.concurrent.ListeningExecutorService;
     import com.google.common.util.concurrent.MoreExecutors;
     
    -class OperatorContextImpl extends AbstractOperatorExecContext implements OperatorContext,
AutoCloseable {
    +class OperatorContextImpl extends BaseOperatorContext implements OperatorContext, AutoCloseable
{
       static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(OperatorContextImpl.class);
    --- End diff --
    
    Why we need to have `OperatorContextImpl implements OperatorContext` when `BaseOperatorContex`t
already implements that interface ?


---

Mime
View raw message