drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sohami <...@git.apache.org>
Subject [GitHub] drill issue #978: DRILL-5842: Refactor and simplify the fragment, operator c...
Date Wed, 01 Nov 2017 00:56:50 GMT
Github user sohami commented on the issue:

    https://github.com/apache/drill/pull/978
  
    Looking into the PR and based on description it says below:
    
    _A result of these changes is that OperatorContext is now a one-stop-shop for services
needed by operators. It now provides:_
    
    - Access to the fragment context: getFragmentContext()
    - Access to the physical operator definition (AKA “physical operator”): getOperatorDefn().
    
    _Because of these changes, we need no longer pass around the triple of fragment context,
operator definition and operator context — something needed by the “managed” sort and
upcoming PRs._
    
    Based on my understanding it looks like existing interface and implementation `OperExecContextImpl`
do provide access to `FragmentContext` and `PopConfig` (operator Defn). The instance of this
context is created inside `ExternalSortBatch` which has access to FragmentContext and PopConfig
already. Also `SortImpl` only takes in `OperExecContext`. I am little confused how the change
avoided the need to pass around the triplet ?


---

Mime
View raw message