drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vlad-Storona <...@git.apache.org>
Subject [GitHub] drill pull request #774: DRILL-5337: OpenTSDB storage plugin
Date Thu, 02 Nov 2017 15:28:50 GMT
Github user Vlad-Storona commented on a diff in the pull request:

    https://github.com/apache/drill/pull/774#discussion_r148568059
  
    --- Diff: contrib/storage-opentsdb/src/main/java/org/apache/drill/exec/store/openTSDB/OpenTSDBStoragePluginConfig.java
---
    @@ -0,0 +1,60 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.store.openTSDB;
    +
    +import com.fasterxml.jackson.annotation.JsonCreator;
    +import com.fasterxml.jackson.annotation.JsonProperty;
    +import com.fasterxml.jackson.annotation.JsonTypeName;
    +import org.apache.drill.common.logical.StoragePluginConfigBase;
    +
    +import java.io.IOException;
    +import java.util.Objects;
    +
    +@JsonTypeName(OpenTSDBStoragePluginConfig.NAME)
    +public class OpenTSDBStoragePluginConfig extends StoragePluginConfigBase {
    +
    +  public static final String NAME = "openTSDB";
    +
    +  private final String connection;
    +
    +  @JsonCreator
    +  public OpenTSDBStoragePluginConfig(@JsonProperty("connection") String connection) throws
IOException {
    +    this.connection = connection;
    --- End diff --
    
    Yes, we should. I will add null check.


---

Mime
View raw message