drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arina Ielchiieva (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (DRILL-5746) Pcap PR manually edited Protobuf files, values lost on next build
Date Tue, 07 Nov 2017 10:32:00 GMT

     [ https://issues.apache.org/jira/browse/DRILL-5746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Arina Ielchiieva resolved DRILL-5746.
    Resolution: Fixed

In the scope of DRILL-5716.

> Pcap PR manually edited Protobuf files, values lost on next build
> -----------------------------------------------------------------
>                 Key: DRILL-5746
>                 URL: https://issues.apache.org/jira/browse/DRILL-5746
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.10.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>             Fix For: 1.12.0
> Drill recently accepted the pcap format plugin. As part of that work, the author added
a new operator type, {{PCAP_SUB_SCAN_VALUE}}.
> But, apparently this was done by editing the generated Protobuf files to add the values,
rather than modifying the protobuf definitions and rebuilding the generated files. The result
is, on the next build of the Protobuf sources, the following compile error appears:
> {code}
> [ERROR] /Users/paulrogers/git/drill/exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapFormatPlugin.java:[80,41]
error: cannot find symbol
> [ERROR] symbol:   variable PCAP_SUB_SCAN_VALUE
> [ERROR] location: class CoreOperatorType
> {code}
> The solution is to properly edit the Protobuf definitions with the required symbol.

This message was sent by Atlassian JIRA

View raw message