drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jiang-wu <...@git.apache.org>
Subject [GitHub] drill pull request #1247: DRILL-6242 Use java.time.Local{Date|Time|DateTime}...
Date Tue, 01 May 2018 23:12:55 GMT
Github user jiang-wu commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1247#discussion_r185358343
  
    --- Diff: exec/vector/src/main/java/org/apache/drill/exec/expr/fn/impl/DateUtility.java
---
    @@ -639,29 +648,95 @@ public static String getTimeZone(int index) {
         return timezoneList[index];
       }
     
    +  /**
    --- End diff --
    
    The "parseLocalDate", "parseLocalTime", "parseLocalDateTime" are used by various junit
tests.  These parsers are strict in that if the input string doesn't have all the specified
fields, it will fail to parse.


---

Mime
View raw message