drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sohami <...@git.apache.org>
Subject [GitHub] drill pull request #1241: DRILL-6364: Handle Cluster Info in WebUI when exis...
Date Wed, 02 May 2018 06:53:49 GMT
Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1241#discussion_r185406458
  
    --- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
    @@ -328,9 +432,11 @@
           //Iterates through all the nodes for update
           function reloadMetrics() {
               for (i = 1; i <= size; i++) {
    -              var address = $("#row-"+i).find("#address").contents().get(0).nodeValue.trim();
    -              var httpPort = $("#row-"+i).find("#httpPort").contents().get(0).nodeValue.trim();
    -              updateMetricsHtml(address, httpPort, i);
    +              if ( $("#row-"+i).find("#stateKey").length == 0 ) {
    +                var address = $("#row-"+i).find("#address").contents().get(0).nodeValue.trim();
    +                var httpPort = $("#row-"+i).find("#httpPort").contents().get(0).nodeValue.trim();
    +                updateMetricsHtml(address, httpPort, i);
    --- End diff --
    
    Not true please see the braces. They evaluate to different outcome.


---

Mime
View raw message