drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vrozov <...@git.apache.org>
Subject [GitHub] drill pull request #1225: DRILL-6272: Refactor dynamic UDFs and function ini...
Date Wed, 02 May 2018 13:37:57 GMT
Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1225#discussion_r185497944
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/coord/zk/TestZookeeperClient.java
---
    @@ -125,7 +125,7 @@ public void testHasPathThrowsDrillRuntimeException() {
     
         Mockito
             .when(client.getCache().getCurrentData(absPath))
    -        .thenThrow(Exception.class);
    +        .thenThrow(RuntimeException.class);
    --- End diff --
    
    IMO, this method needs to be changed to test `ZookeeperClient.hasPath(String path, boolean
consistent)`. It is OK to do it in this PR or in a separate commit/JIRA/PR. If you decide
to do it in a separate commit, please file JIRA.


---

Mime
View raw message