From dev-return-37824-apmail-drill-dev-archive=drill.apache.org@drill.apache.org Tue May 1 13:54:10 2018 Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C981E10943 for ; Tue, 1 May 2018 13:54:10 +0000 (UTC) Received: (qmail 35000 invoked by uid 500); 1 May 2018 13:54:10 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 34917 invoked by uid 500); 1 May 2018 13:54:10 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 34902 invoked by uid 99); 1 May 2018 13:54:09 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 May 2018 13:54:09 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 3BBA6DFF14; Tue, 1 May 2018 13:54:09 +0000 (UTC) From: vrozov To: dev@drill.apache.org Reply-To: dev@drill.apache.org References: In-Reply-To: Subject: [GitHub] drill pull request #1224: DRILL-6321: Customize Drill's conformance. Allow s... Content-Type: text/plain Message-Id: <20180501135409.3BBA6DFF14@git1-us-west.apache.org> Date: Tue, 1 May 2018 13:54:09 +0000 (UTC) Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1224#discussion_r185225979 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillConformance.java --- @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.planner.sql; + +import org.apache.calcite.sql.validate.SqlConformanceEnum; +import org.apache.calcite.sql.validate.SqlDelegatingConformance; + +/** + * Drill's SQL conformance is SqlConformanceEnum.DEFAULT except for method isApplyAllowed(). + * Since Drill is going to allow OUTER APPLY and CROSS APPLY to allow each row from left child of Join + * to join with output of right side (sub-query or table function that will be invoked for each row). + * Refer to DRILL-5999 for more information. + */ +public class DrillConformance extends SqlDelegatingConformance { --- End diff -- If changes are introduced to `DrillConformance`, it can be refactored later to be a top-level class. For now, I suggest avoid optimizing for future requirements that may never materialize. ---