From dev-return-37881-apmail-drill-dev-archive=drill.apache.org@drill.apache.org Wed May 2 13:37:59 2018 Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7710F18C4E for ; Wed, 2 May 2018 13:37:59 +0000 (UTC) Received: (qmail 92472 invoked by uid 500); 2 May 2018 13:37:59 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 92398 invoked by uid 500); 2 May 2018 13:37:59 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 92383 invoked by uid 99); 2 May 2018 13:37:58 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 May 2018 13:37:58 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 21DAFE09E9; Wed, 2 May 2018 13:37:57 +0000 (UTC) From: vrozov To: dev@drill.apache.org Reply-To: dev@drill.apache.org References: In-Reply-To: Subject: [GitHub] drill pull request #1225: DRILL-6272: Refactor dynamic UDFs and function ini... Content-Type: text/plain Message-Id: <20180502133758.21DAFE09E9@git1-us-west.apache.org> Date: Wed, 2 May 2018 13:37:57 +0000 (UTC) Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1225#discussion_r185497944 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/coord/zk/TestZookeeperClient.java --- @@ -125,7 +125,7 @@ public void testHasPathThrowsDrillRuntimeException() { Mockito .when(client.getCache().getCurrentData(absPath)) - .thenThrow(Exception.class); + .thenThrow(RuntimeException.class); --- End diff -- IMO, this method needs to be changed to test `ZookeeperClient.hasPath(String path, boolean consistent)`. It is OK to do it in this PR or in a separate commit/JIRA/PR. If you decide to do it in a separate commit, please file JIRA. ---