drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ted Dunning <ted.dunn...@gmail.com>
Subject Re: bad commit
Date Sat, 02 Jun 2018 08:20:02 GMT
Abhishek is right. You can reopen the PR.



On Sat, Jun 2, 2018 at 6:46 AM Abhishek Girish <agirish@apache.org> wrote:

> Can't the PR be reopened? I see that option on GitHub. So maybe we could
> revert the commit, and merge the PR later when unit tests are fine?
> On Fri, Jun 1, 2018 at 10:02 PM Parth Chandra <parthc@apache.org> wrote:
>
> > I accidentally committed a PR that had a failing unit test.
> > I can revert the commit, but the PR is closed (
> > https://github.com/apache/drill/pull/309).
> >
> > Any thoughts/suggestions on how to rectify this?
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message