drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature
Date Sun, 01 Jul 2018 16:43:11 GMT
amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature
URL: https://github.com/apache/drill/pull/1334#discussion_r199334349
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/HashJoinPOP.java
 ##########
 @@ -32,35 +33,53 @@
 import com.google.common.base.Preconditions;
 import com.google.common.collect.Lists;
 import org.apache.drill.exec.physical.base.AbstractJoinPop;
+import org.apache.drill.exec.work.filter.RuntimeFilterDef;
+
 
 @JsonTypeName("hash-join")
+@JsonIgnoreProperties(ignoreUnknown = true)
 
 Review comment:
   Instead of ignoring the property at global class level,  can you ignore specific one using
`@JsonIgnore` ?  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message