drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] Ben-Zvi commented on a change in pull request #1351: DRILL-6543: Disable Hash Join fallback, add percent_reserved_allowance_from_direct
Date Wed, 04 Jul 2018 01:11:57 GMT
Ben-Zvi commented on a change in pull request #1351: DRILL-6543: Disable Hash Join fallback,
add percent_reserved_allowance_from_direct
URL: https://github.com/apache/drill/pull/1351#discussion_r199986966
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/util/MemoryAllocationUtilities.java
 ##########
 @@ -138,16 +139,36 @@ public static long computeOperatorMemory(OptionSet optionManager, long
maxAllocP
   @VisibleForTesting
   public static long computeQueryMemory(DrillConfig config, OptionSet optionManager, long
directMemory) {
 
+    // Get the options
+    double percent_per_query = optionManager.getOption(ExecConstants.PERCENT_MEMORY_PER_QUERY);
 
 Review comment:
   Fixed ....
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message