drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] superbstreak commented on a change in pull request #1366: [DRILL-6581] C++ Client SSL Implementation Fixes/Improvements
Date Sat, 07 Jul 2018 02:18:21 GMT
superbstreak commented on a change in pull request #1366: [DRILL-6581] C++ Client SSL Implementation
Fixes/Improvements
URL: https://github.com/apache/drill/pull/1366#discussion_r200799915
 
 

 ##########
 File path: contrib/native/client/src/clientlib/channel.hpp
 ##########
 @@ -170,7 +190,22 @@ class UserProperties;
                 try{
                     m_pSocket->protocolHandshake(useSystemConfig);
                 } catch (boost::system::system_error e) {
-                    status = handleError(CONN_HANDSHAKE_FAILED, e.what());
+                    const std::string errmsg(e.what());
+                    if (m_pContext->HasCertHostnameVerificationError()){
 
 Review comment:
   make sure m_psocket is actually ssl task before we check for ssl specific exceptions. Currently,
there is no impact since the normal socket's protoHandshake doesn't do any task. But should
take care of it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message