drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] arina-ielchiieva commented on a change in pull request #1371: DRILL-6588: Make Sys tables of nullable datatypes
Date Wed, 11 Jul 2018 09:45:38 GMT
arina-ielchiieva commented on a change in pull request #1371: DRILL-6588: Make Sys tables of
nullable datatypes
URL: https://github.com/apache/drill/pull/1371#discussion_r201626723
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pojo/PojoDataType.java
 ##########
 @@ -48,22 +51,25 @@ public PojoDataType(Class<?> pojoClass) {
       Class<?> type = f.getType();
       names.add(f.getName());
 
+      //Absence of annotation @Nonnull => (isNullable=true)
+      final boolean isNullable = f.isAnnotationPresent(Nonnull.class) ? false : true;
 
 Review comment:
   This can be simplified to `! f.isAnnotationPresent(Nonnull.class)`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message