drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] vdiravka commented on a change in pull request #1372: DRILL-6589: Push transitive closure predicates past aggregates/projects
Date Wed, 11 Jul 2018 11:18:40 GMT
vdiravka commented on a change in pull request #1372: DRILL-6589: Push transitive closure predicates
past aggregates/projects
URL: https://github.com/apache/drill/pull/1372#discussion_r201641542
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRelFactories.java
 ##########
 @@ -92,7 +97,7 @@ public RelNode createProject(RelNode child,
 
   /**
    * Implementation of {@link RelFactories.FilterFactory} that
-   * returns a vanilla {@link LogicalFilter}.
+   * returns a vanilla LogicalFilter.
 
 Review comment:
   You can add it to import. But looks like it is wrong statement, this returns `DrillFilterRel`
not `LogicalFilter`. 
   The same for `LogicalProject` and `LogicalJoin`. Please change it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message