drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] vdiravka commented on a change in pull request #1372: DRILL-6589: Push transitive closure predicates past aggregates/projects
Date Wed, 11 Jul 2018 11:18:41 GMT
vdiravka commented on a change in pull request #1372: DRILL-6589: Push transitive closure predicates
past aggregates/projects
URL: https://github.com/apache/drill/pull/1372#discussion_r201642791
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRelFactories.java
 ##########
 @@ -122,4 +127,16 @@ public RelNode createJoin(RelNode left, RelNode right,
     }
   }
 
+  private static class DrillAggregateFactoryImpl implements RelFactories.AggregateFactory
{
+
+    @Override
+    public RelNode createAggregate(RelNode input, boolean indicator, ImmutableBitSet groupSet,
+                                   ImmutableList<ImmutableBitSet> groupSets, List<AggregateCall>
aggCalls) {
+      try {
+        return new DrillAggregateRel(input.getCluster(), input.getTraitSet(), input, indicator,
groupSet, groupSets, aggCalls);
+      } catch (InvalidRelException ex) {
 
 Review comment:
   see `InvalidRelException` description. It should be logged at debug level.
   Is it safe to work further with null?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message