drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] vdiravka commented on a change in pull request #1372: DRILL-6589: Push transitive closure predicates past aggregates/projects
Date Wed, 11 Jul 2018 11:18:41 GMT
vdiravka commented on a change in pull request #1372: DRILL-6589: Push transitive closure predicates
past aggregates/projects
URL: https://github.com/apache/drill/pull/1372#discussion_r201650457
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/RuleInstance.java
 ##########
 @@ -140,4 +145,14 @@
 
   SubQueryRemoveRule SUB_QUERY_JOIN_REMOVE_RULE =
       new SubQueryRemoveRule.SubQueryJoinRemoveRule(DrillRelFactories.LOGICAL_BUILDER);
+
+  FilterAggregateTransposeRule DRILL_FILTER_AGGREGATE_TRANSPOSE_RULE =
 
 Review comment:
   Could you add this Instance in the `DrillFilterAggregateTransposeRule` as `DRILL_INSTANCE`?

   Do we want to match Filter and Aggregate with mixed `CONVENTION` `Trait` (see `DrillFilterAggregateTransposeRule#matches()`)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message