drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ilooner commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker Container
Date Wed, 11 Jul 2018 22:25:33 GMT
ilooner commented on a change in pull request #1348: DRILL-6346: Create an Official Drill Docker
Container
URL: https://github.com/apache/drill/pull/1348#discussion_r201858385
 
 

 ##########
 File path: distribution/Dockerfile
 ##########
 @@ -0,0 +1,35 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+FROM centos:7
+
+# Project version defined in pom.xml is passed as an argument
+ARG VERSION
+
+# JDK 8 is a pre-requisite to run Drill ; 'which' package is needed for drill-config.sh
+RUN yum install -y java-1.8.0-openjdk-devel which ; yum clean all ; rm -rf /var/cache/yum
+
+# The drill tarball is generated upon building the Drill project
+COPY target/apache-drill-$VERSION.tar.gz /tmp
+
+# Drill binaries are extracted into the '/opt/drill' directory
+RUN mkdir /opt/drill
+RUN tar -xvzf /tmp/apache-drill-$VERSION.tar.gz --directory=/opt/drill --strip-components
1
+
+# Starts Drill in embedded mode and connects to Sqlline
+ENTRYPOINT /opt/drill/bin/drill-embedded
 
 Review comment:
   I've typically seen docker images use environmental variables to pass in parameters. If
zookeeper is deployed on Kubernetes, wouldn't the nodes have static hostnames and ports like
node.zk1, node.zk2? If so we could have a ZK_HOSTS variable which overrides drill config,
and users can set the appropriate values for ZK_HOSTS in their drill pod definition yaml.
   
   Behind the scenes a script could update the drill config file appropriately depending on
whether ZK_HOSTS is defined or not before launching the drillbit.
   
   Or are config maps some kubernetes magic that let's us avoid all this boilerplate?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message