drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] paul-rogers commented on issue #1367: DRILL-6585: PartitionSender clones vectors, but shares field metdata
Date Wed, 11 Jul 2018 22:59:17 GMT
paul-rogers commented on issue #1367: DRILL-6585: PartitionSender clones vectors, but shares
field metdata
URL: https://github.com/apache/drill/pull/1367#issuecomment-404336471
 
 
   @vrozov, can you take another look at this PR to see if I have addressed your concerns?
   
   Turned out that I was able to find an existing `MaterializedField.clone()` method. Since
only the `PartitionerTemplate` seems to have an issue, I just inserted the extra call directly
there, avoiding the need to modify any other files.
   
   If we can test this fix using PR #1244, then perhaps we can get this fix into this week's
batch commit, PR #1244 into next week's, after which I can do the final PR for this batch
of changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message