drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] kkhatua commented on a change in pull request #1371: DRILL-6588: Make Sys tables of nullable datatypes
Date Thu, 12 Jul 2018 01:04:49 GMT
kkhatua commented on a change in pull request #1371: DRILL-6588: Make Sys tables of nullable
datatypes
URL: https://github.com/apache/drill/pull/1371#discussion_r201883141
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/BitToUserConnectionIterator.java
 ##########
 @@ -99,14 +102,18 @@ public void remove() {
 
   public static class ConnectionInfo {
     public String user;
+    @Nonnull
 
 Review comment:
   Ok. Got it. This is part of the annotations-2.0.1 dependency that drill has in its 3rd
party library (`com.google.code.findbugs`). It might be used here in a context different from
what it was intended to be used for.
   So, @arina-ielchiieva / @paul-rogers , should I go ahead with this usage or revert to implementing
the annotation class I originally had?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message