drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] amansinha100 commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest
Date Fri, 27 Jul 2018 23:20:05 GMT
amansinha100 commented on a change in pull request #1401: DRILL-6616: Batch Processing for
Lateral/Unnest
URL: https://github.com/apache/drill/pull/1401#discussion_r205919958
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java
 ##########
 @@ -317,6 +319,33 @@ public Void visitCall(RexCall call) {
     }
   }
 
+  /**
+   * Given a list of rexnodes it transforms the rexnodes by changing the expr to use new
index mapped to the old index.
+   * @param builder : RexBuilder from the planner.
+   * @param exprs: RexNodes to be transformed.
+   * @param corrMap: Mapping between old index to new index.
+   * @return
+   */
+  public static List<RexNode> transformExprs(RexBuilder builder, List<RexNode>
exprs, Map<Integer, Integer> corrMap) {
 
 Review comment:
   Doesn't Calcite already provide similar transformation in RexUtil ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message