drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] HanumathRao commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest
Date Mon, 30 Jul 2018 17:05:35 GMT
HanumathRao commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest
URL: https://github.com/apache/drill/pull/1401#discussion_r206249561
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/FilterPrel.java
 ##########
 @@ -81,4 +86,17 @@ public boolean needsFinalColumnReordering() {
     return true;
   }
 
+  @Override
+  public Prel addImplicitRowIDCol(List<RelNode> children) {
+    RexBuilder builder = this.getCluster().getRexBuilder();
+    return (Prel) this.copy(this.traitSet, children.get(0), DrillRelOptUtil.transformExpr(builder,
condition, buildMap()));
+  }
+
+  private Map<Integer, Integer> buildMap() {
+    Map<Integer, Integer> map = new HashMap<>();
+    for (int i=0;i<this.getInput().getRowType().getFieldCount();i++) {
+      map.put(i, i+1);
 
 Review comment:
   Yes. I did consider this option but for aggregations calcite expects to place the group
by columns at the beginning of the row type. Hence, I thought it is better to do this uniformly
across all other operators as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message