vdiravka commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds
exception to UserException with …
URL: https://github.com/apache/drill/pull/1455#discussion_r214697604
##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/bson/BsonRecordReader.java
##########
@@ -364,13 +367,14 @@ public void ensureAtLeastOneField(ComplexWriter writer) {
}
}
- public UserException.Builder getExceptionWithContext(UserException.Builder exceptionBuilder,
String field,
- String msg, Object... args) {
- return null;
- }
-
- public UserException.Builder getExceptionWithContext(Throwable exception, String field,
String msg, Object... args) {
- return null;
+ public UserException.Builder createExceptionWithContext(Throwable cause, String message)
{
Review comment:
It will be better to lead it to the same method name as `JsonProcessor.getExceptionWithContext()`
for consistency.
Because naturally in Mongo both `JsonReader` and `BsonBinaryreader` extend `AbstractBsonReader`
https://github.com/mongodb/mongo-java-driver/blob/master/bson/src/main/org/bson/json/JsonReader.java#L64
Possibly it should be improved in Drill in future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
|