drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] vdiravka commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds exception to UserException with …
Date Mon, 03 Sep 2018 14:47:05 GMT
vdiravka commented on a change in pull request #1455: DRILL-6724: Convert IndexOutOfBounds
exception to UserException with …
URL: https://github.com/apache/drill/pull/1455#discussion_r214687014
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/RecordReader.java
 ##########
 @@ -49,4 +50,15 @@
    * @return The number of additional records added to the output.
    */
   int next();
+
+  /**
+   * Creates {@link UserException} with reader context. Should be analogous to
+   * {@link UserException#dataReadError(Throwable)} with provided context data.
+   * Returns {@code null} if context for a reader is unavailable.
+   *
+   * @param cause a {@code Throwable} to be wrapped into {@code UserException}
+   * @param message message to be passed to resulting {@code UserException}. Nullable
+   * @return exception with context data
 
 Review comment:
   just add `instance` word to clarify that it is not thrown, but returned.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message