drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] arina-ielchiieva commented on a change in pull request #1726: DRILL-7143: Support default value for empty columns
Date Sun, 07 Apr 2019 13:19:50 GMT
arina-ielchiieva commented on a change in pull request #1726: DRILL-7143: Support default value
for empty columns
URL: https://github.com/apache/drill/pull/1726#discussion_r272834240
 
 

 ##########
 File path: common/src/main/java/org/apache/drill/common/types/BooleanType.java
 ##########
 @@ -15,45 +15,39 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.apache.drill.exec.expr;
+package org.apache.drill.common.types;
 
-import org.apache.drill.common.map.CaseInsensitiveMap;
-
-import java.util.Arrays;
-import java.util.List;
 import java.util.Map;
 
+import org.apache.drill.common.map.CaseInsensitiveMap;
+
 /**
  * Enum that contains two boolean types: TRUE and FALSE.
  * Each has numeric representation and list of allowed literals.
  * List of literals if formed according to
  * {@link <a href="https://www.postgresql.org/docs/9.6/static/datatype-boolean.html">Postgre
Documentation</a>}
  */
 public enum BooleanType {
-  TRUE(1, Arrays.asList("t", "true", "y", "yes", "on", "1")),
-  FALSE(0, Arrays.asList("f", "false", "n", "no", "off", "0"));
+  TRUE(1, new String [] {"true", "1", "t", "y", "yes", "on",}),
+  FALSE(0, new String [] {"false", "0", "f", "n", "no", "off"});
 
   private final int numericValue;
-  private final List<String> literals;
+  private final String[] literals;
 
-  BooleanType(int numericValue, List<String> literals) {
+  BooleanType(int numericValue, String literals[]) {
 
 Review comment:
   Please fix array declaration.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message