drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [drill] amansinha100 commented on a change in pull request #1728: DRILL-7089: Implement caching for TableMetadataProvider at query level and adapt statistics to use Drill metastore API
Date Sun, 07 Apr 2019 19:06:16 GMT
amansinha100 commented on a change in pull request #1728: DRILL-7089: Implement caching for
TableMetadataProvider at query level and adapt statistics to use Drill metastore API
URL: https://github.com/apache/drill/pull/1728#discussion_r272845887
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/MetadataProviderManager.java
 ##########
 @@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.physical.base;
+
+import org.apache.drill.exec.planner.common.DrillStatsTable;
+import org.apache.drill.exec.record.metadata.schema.SchemaProvider;
+
+/**
+ * Base interface for passing and obtaining {@link SchemaProvider}, {@link DrillStatsTable}
and
+ * {@link TableMetadataProvider}, responsible for creating required
+ * {@link TableMetadataProviderBuilder} which constructs required {@link TableMetadataProvider}
+ * based on specified providers
+ */
+public interface MetadataProviderManager {
 
 Review comment:
   Since the `TableMetadataProvider` is supposed to provide the Schema and the Statistics,
it is not clear why the `MetadataProviderManager` also exposes the SchemaProvider and the
StatsProvider which in some sense are 'children' of the `TableMetadataProvider`  since a Table
must exist in order for its Schema and Statistics to exist. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message