amansinha100 commented on a change in pull request #1738: DRILL-7062: Initial implementation
of run-time row-group pruning
URL: https://github.com/apache/drill/pull/1738#discussion_r272860264
##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/AbstractParquetScanBatchCreator.java
##########
@@ -149,6 +219,77 @@ protected ScanBatch getBatch(ExecutorFragmentContext context, AbstractParquetRow
return new ScanBatch(context, oContext, readers, implicitColumns);
}
+ /**
+ * Create a reader and add it to the list of readers.
+ *
+ * @param context
+ * @param rowGroupScan
+ * @param oContext
+ * @param columnExplorer
+ * @param readers
+ * @param implicitColumns
+ * @param mapWithMaxColumns
+ * @param rowGroup
+ * @param fs
+ * @param footer
+ * @param readSchemaOnly - if true sets the number of rows to read to be zero
+ * @return
Review comment:
Add a brief description of the return
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
|